-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade from Chromium 134 to Chromium 135 #27522
Draft
cdesouza-chromium
wants to merge
139
commits into
master
Choose a base branch
from
cr135
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+10,523
−3,160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A Storybook has been deployed to preview UI for the latest push |
691402f
to
065a4b6
Compare
d098ee0
to
9234786
Compare
bee1202
to
8575b2f
Compare
de9d787
to
f5f8f8c
Compare
This attribute has been deleted from grit, and isn't recognised anymore. Chromium change: https://chromium.googlesource.com/chromium/src/+/96c98d3ae26486007669c1cd00e4da58c85659b3 commit 96c98d3ae26486007669c1cd00e4da58c85659b3 Author: dpapad <[email protected]> Date: Tue Feb 4 16:23:24 2025 -0800 Grit: Remove output_all_resource_defines from list of valid attributes. All references to this attribute have been removed in previous CLs, both from public and internal repositories. Fixed: 389466679
This update to `gtest` affect just a few places. Chromium change: https://chromium.googlesource.com/external/github.com/google/googletest.git/+/3fbe4db9a39291ae8d7a9c5f1d75896bb4c5a18f commit 3fbe4db9a39291ae8d7a9c5f1d75896bb4c5a18f Author: Derek Mauro <[email protected]> Date: Fri Feb 21 07:33:10 2025 -0800 GoogleTest C++17 cleanups * Use `[[nodiscard]]` instead of GTEST_MUST_USE_RESULT_ * Use `[[maybe_unused]]` instead of GTEST_INTERNAL_ATTRIBUTE_MAYBE_UNUSED * Use `[[deprecated]]` instead of `GTEST_INTERNAL_DEPRECATED` * Remove `GTEST_INTERNAL_NEED_REDUNDANT_CONSTEXPR_DECL` PiperOrigin-RevId: 729523519 Change-Id: Ia1b901cf9c0a0e148eec419ada0e0b56aba2dd3d
This affects the functions we are calling, but it also dispenses the use of one substitution in place to force upstream code to use `ColorVariant`. Chromium change: https://chromium.googlesource.com/chromium/src/+/e4ae2a14a8ee22ceb0517a62ba7471f78b9b9251 commit e4ae2a14a8ee22ceb0517a62ba7471f78b9b9251 Author: Zoraiz Naeem <[email protected]> Date: Wed Feb 26 12:47:22 2025 -0800 Migrated `LabelButton` to use ui::ColorVariant Bug: b:394420459
This affects the return of `IsUrlMapped`, which now requires a value to be checked for, rather than just returning a bool. Chromium change: https://chromium.googlesource.com/chromium/src/+/859690d472e75c063d1f09e8eef083dffef49bd0 commit 859690d472e75c063d1f09e8eef083dffef49bd0 Author: Janice Liu <[email protected]> Date: Wed Feb 26 07:52:51 2025 -0800 [Blob URL] Update PartitioningBlobURLIssue DevTools Issue, Add kCrossPartitionSameOriginBlobURLFetch UseCounter Both the PartitioningBlobURLIssue DevTools Issue and kCrossPartitionSameOriginBlobURLFetch UseCounter should only be triggered when cross-partition, same origin BlobURLs are fetched. Previously, both were getting triggered in cross origin fetching as well. Bug: 372883697
The patch file was moved to the new file name for the implementation. Chromium change: https://chromium.googlesource.com/chromium/src/+/f74255f5e258d778ab817339639a2a50f67f9fce commit f74255f5e258d778ab817339639a2a50f67f9fce Author: Shuhei Takahashi <[email protected]> Date: Wed Feb 26 17:59:43 2025 -0800 extensions: Compile ExtensionInfoGenerator for Desktop Android This patch introduces a new base class ExtensionInfoGeneratorShared that fills a portion of ExtensionInfo common to all platforms. On Android, it is aliased to ExtensionInfoGenerator. On other desktop platforms, ExtensionInfoGenerator is defined to derive from the base class to fill all ExtensionInfo fields. Bug: 392777363
This PR was patched into M134 in brave, however it has now landed in M135. Chromium change: https://chromium.googlesource.com/chromium/src/+/e6deab359b874348fb8761e18764c6249d17ac85 commit e6deab359b874348fb8761e18764c6249d17ac85 Author: Anthony Tseng <[email protected]> Date: Mon Feb 24 13:04:06 2025 -0800 Use browser context specific URLLoaderFactory for InMemoryDownloadService Bring back profile URLLoaderFactory by async retrieving through FullBrowserTransitionManager without breaking DownloadServiceFactory as a SKSF (SimpleKeyedServiceFactory). Bug: 395544421
This is a trend with permission polices moving out of blink. This particular change only affects feature flags. Chromium change: https://chromium.googlesource.com/chromium/src/+/f42e6bd64cdb0afed53cbec711f7b9249353c87d commit f42e6bd64cdb0afed53cbec711f7b9249353c87d Author: Sandor Major <[email protected]> Date: Thu Feb 27 16:12:04 2025 -0800 Move permissions_policy.cc-used feature flags to the Network service Permissions Policy code is being moved to the Network service so these flags need to move as well. Bug: 382291442
This only affects the path for a single inclusion header. Chromium change: https://chromium.googlesource.com/chromium/src/+/9c6a9a1fff68e133a2329104c77d77858f75c6b3 commit 9c6a9a1fff68e133a2329104c77d77858f75c6b3 Author: Florian Leimgruber <[email protected]> Date: Thu Feb 27 07:09:13 2025 -0800 Move Autofill payments data model files into subdirectory In an effort to split components/autofill/core/browser/data_model into addresses, autofill_ai, passes and payments subdirectories, this CL moves all payments related files. The CL was auto-generated as follows: cd components/autofill/core/browser/data_model mkdir payments git mv bank_account* payments git mv bnpl* payments git mv credit_card* payments git mv iban* payments git mv *offer* payments git mv payment_* payments git mv payments_* payments git mv *wallet* payments cd ../../../../.. ./tools/git/mass-rename.py git cl format Bug: 376223525
Chromium change: https://chromium.googlesource.com/chromium/src/+/6b88305d9871a487e87b7eb9991f5fbe36940d85 [TSLO] Fix status bar coloration in desktop windowing mode The status bar currently always uses the default tab strip background color on a tablet when the strip is visible irrespective of the focus state of the activity window. The strip background color changes from the default for an unfocused desktop window and if the status bar is contiguous with an unfocused desktop window, it incorrectly still uses the default color that is applied only to a focused tab strip. This CL makes an update to ensure that the status bar uses the same color applied to the tab strip, which can be impacted by the activity focus state. Before: https://screenshot.googleplex.com/9uKWnPUYcouZFSm After: https://screenshot.googleplex.com/AQVoLoAkvwqVvQG Bug: 393443576
Chromium change: https://chromium.googlesource.com/chromium/src/+/a9bdd13cde6f7a4bca9768d85b7b4dabf10880bb commit a9bdd13cde6f7a4bca9768d85b7b4dabf10880bb Author: Ryan Tarpine <[email protected]> Date: Fri Feb 28 12:29:34 2025 -0800 [BTM] Rename files/directories prefixed with "dips" to "btm". Fixed: 399868999
This feature is part of the broader `Prerender2` functionality that is disabled in brave. Chromium change: https://chromium.googlesource.com/chromium/src/+/d5c1359a8b21630a745cb2f4fb8776904ea2e82a commit d5c1359a8b21630a745cb2f4fb8776904ea2e82a Author: Hiroki Nakagawa <[email protected]> Date: Fri Feb 28 01:34:34 2025 -0800 Prerender: Remove kSupportSearchSuggestionForPrerender2 for cleanup This flag has been enabled by default since M131 (https://crrev.com/c/5790323). Also, the default search engine can configure this feature without the feature flag. Bug: 360158401
This feature flag is now under a new path and namespace. Chromium change: https://chromium.googlesource.com/chromium/src/+/d5c1359a8b21630a745cb2f4fb8776904ea2e82a commit d5c1359a8b21630a745cb2f4fb8776904ea2e82a Author: Hiroki Nakagawa <[email protected]> Date: Fri Feb 28 01:34:34 2025 -0800 Prerender: Remove kSupportSearchSuggestionForPrerender2 for cleanup This flag has been enabled by default since M131 (https://crrev.com/c/5790323). Also, the default search engine can configure this feature without the feature flag. Bug: 360158401
This type was only being used in brave to satisfy calling `BookmarkBubbleView::ShowBubble`. Chromium change: https://chromium.googlesource.com/chromium/src/+/8f05b4e8884847a43dd2731d82d058c0f8da2319 commit 8f05b4e8884847a43dd2731d82d058c0f8da2319 Author: Amelie Schneider <[email protected]> Date: Fri Feb 28 02:02:53 2025 -0800 [B4B] Combine into single `BubbleSignInPromoDelegate` Merges `BookmarkBubbleSignInDelegate` and `ExtensionInstalledBubbleView` into `BubbleSignInPromoDelegate`. Bug: 399326930
This change has caused a build failure as dereferencing it was being done as a pointer before. Chromium change: https://chromium.googlesource.com/chromium/src/+/e94b3c882d13316aadf8db6de02ec7e442beba48 commit e94b3c882d13316aadf8db6de02ec7e442beba48 Author: Shuhei Takahashi <[email protected]> Date: Thu Feb 27 18:33:14 2025 -0800 extensions: Pass around ExtensionInfo without unique_ptr This is a follow-up of crrev.com/c/6307985. Bug: b/392777363
This change preempts the inclusion of `ChromeExtensionRegistrarDelegate` to avoid build failures relating to the substitution done for `ComponentLoader`. Chromium change: https://chromium.googlesource.com/chromium/src/+/23bd5098f3d8b2767e27d46089a4698e709485ef commit 23bd5098f3d8b2767e27d46089a4698e709485ef Author: James Cook <[email protected]> Date: Thu Feb 27 18:19:36 2025 -0800 extensions: Refactor ChromeExtensionRegistrarDelegate, part 1 Specifically, remove some ExtensionService dependencies. This is part of the work to get ChromeExtensionRegistrarDelegate to compile on desktop Android, so we can support extension installation. Bug: 394968360
This reverts commit 35475e0.
Chromium change: https://chromium.googlesource.com/chromium/src.git/+/50fdc26f0bb713bbca68d074fb2d263a4a458b5c commit 50fdc26f0bb713bbca68d074fb2d263a4a458b5c Author: John <[email protected]> Date: Thu Feb 20 19:51:41 2025 -0800 Introduce CWVGlobalState CWVGlobalState will be used to explicitly initialize and teardown internal chromium machinery. This will give us better control over the lifecycle of chromium objects and help us address crashes during app termination.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI/run-audit-deps
Check for known npm/cargo vulnerabilities (audit_deps)
CI/run-network-audit
Run network-audit
CI/run-upstream-tests
Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux)
CI/storybook-url
Deploy storybook and provide a unique URL for each build
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#43864
Resolves brave/brave-browser#44237
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: